Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add timeout to the Framed flush operation. #540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add timeout to the Framed flush operation. #540

wants to merge 1 commit into from

Conversation

iwanbk
Copy link
Member

@iwanbk iwanbk commented Jan 7, 2025 •
edited
Loading

To avoid the flush to stuck

Relates to #529

@iwanbk
add timeout to the Framed flush operation.
9fc8382 
To avoid the flush to stuck
@iwanbk iwanbk requested a review from LeeSmet as a code owner January 7, 2025 07:41
@iwanbk
Copy link
Member Author

iwanbk commented Jan 7, 2025

I set the flush timeout to 180 seconds.
Actually i'm not sure about the value and honestly think that 180 seconds is too much, but keep it because it is harmless anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeSmet LeeSmet Awaiting requested review from LeeSmet LeeSmet is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iwanbk